Reverting segmentation data to Unicode 15.0 #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc,
Manishearth,
aethanyc,
makotokato and
a team
as code owners
robertbastian
changed the title
Manishearth
reviewed
Nov 10, 2023
| { | ||
| break_state_table[index] = break_state; | ||
| } | ||
| fn generate_rule_break_data( |
There was a problem hiding this comment.
nit: document that this is currently always called with a different provider that uses hardcoded data
There was a problem hiding this comment.
Is this blocking? I think that's fairly obvious from the single call site.
There was a problem hiding this comment.
I had to dig a bit. Not blocking
Manishearth
approved these changes
Nov 10, 2023
sffc
reviewed
Nov 11, 2023
| Self { | ||
| source: SourceData { | ||
| trie_type: TrieType::Small, | ||
| icuexport_paths: Some(Arc::new(SerdeCache::new(AbstractFs::Memory( |
There was a problem hiding this comment.
Thought: Good design for SerdeCache that this is so easy to do
sffc
reviewed
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our unversioned rules are not compatible with 15.1 properties data.